- 
                Notifications
    
You must be signed in to change notification settings  - Fork 470
 
Log when FunctionDispatcher is initialized. #6230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
          
 verrfied debugger breaks into a js function with runonstartup set to true for the first invocation with following tasks.json {
  "version": "2.0.0",
  "tasks": [
    {
      "type": "func",
      "command": "host start",
      "isBackground": true,
      "dependsOn": "npm install",
       "problemMatcher": {
        "base": "$func-watch",
        "background": {
          "activeOnStart": true,
          "beginsPattern": "^.*(Job host stopped|signaling restart).*$",
          "endsPattern": "^.*Worker process started and initialized.*$"
        },
       }
    },
    {
      "type": "shell",
      "label": "npm install",
      "command": "npm install"
    },
    {
      "type": "shell",
      "label": "npm prune",
      "command": "npm prune --production",
      "problemMatcher": []
    }
  ]
}
 | 
    
| if (workerInitTask.IsCompleted) | ||
| { | ||
| _logger.LogDebug("Adding http worker channel. workerId:{id}", _httpWorkerChannel.Id); | ||
| State = FunctionInvocationDispatcherState.Initialized; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm...deleted commented lines. No new line here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
8b24ded    to
    ef9413a      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ looks great - thanks!!
| 
           We're currently getting bit by this bug #4384 in production.  We have a python http trigger on consumption plan intermittently failing with:  
  | 
    
Fixes #4384